Merge pull request #353 from derrabus/improvement/explicit-return-types

Add explicit types on ArrayCollection
doctrine · Nov 20, 2022 · d45f038 · d45f038
2 parents 72d3f8c + e418258
commit d45f038
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/ArrayCollection.php b/src/ArrayCollection.php
@@ -170,7 +170,8 @@ public function removeElement(mixed $element)
      * Required by interface ArrayAccess.
      *
      * @param TKey $offset
-     * {@inheritDoc}
+     *
+     * @return bool
      */
     #[ReturnTypeWillChange]
     public function offsetExists(mixed $offset)
@@ -182,7 +183,8 @@ public function offsetExists(mixed $offset)
      * Required by interface ArrayAccess.
      *
      * @param TKey $offset
-     * {@inheritDoc}
+     *
+     * @return T|null
      */
     #[ReturnTypeWillChange]
     public function offsetGet(mixed $offset)
@@ -195,7 +197,8 @@ public function offsetGet(mixed $offset)
      *
      * @param TKey|null $offset
      * @param T         $value
-     * {@inheritDoc}
+     *
+     * @return void
      */
     #[ReturnTypeWillChange]
     public function offsetSet(mixed $offset, mixed $value)
@@ -213,7 +216,8 @@ public function offsetSet(mixed $offset, mixed $value)
      * Required by interface ArrayAccess.
      *
      * @param TKey $offset
-     * {@inheritDoc}
+     *
+     * @return void
      */
     #[ReturnTypeWillChange]
     public function offsetUnset(mixed $offset)
@@ -292,9 +296,7 @@ public function getValues()
         return array_values($this->elements);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    /** @return int */
     #[ReturnTypeWillChange]
     public function count()
     {