Contributing guide #103
Merged
Contributing guide #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 15, 2016 19:03
stof
reviewed
Dec 15, 2016
|
|
||
| ## Travis | ||
|
|
||
| We automatically run your pull request through [Travis CI](http://www.travis-ci.org) |
There was a problem hiding this comment.
I suggest to use https://travis-ci.org here, to avoid going through a useless redirection.
| ## Travis | ||
|
|
||
| We automatically run your pull request through [Travis CI](http://www.travis-ci.org) | ||
| against PHP 5.5, PHP 5.6, PHP 7 and HHVM. If you break the tests, we cannot merge your code, |
There was a problem hiding this comment.
I would say against supported PHP versions to avoid having to maintain this list when it changes
| @@ -13,7 +13,8 @@ | |||
| {"name": "Johannes Schmitt", "email": "schmittjoh@gmail.com"} | |||
| ], | |||
| "require": { | |||
| "php": "^5.5 || ^7.0" | |||
| "php": "^5.5 || ^7.0", | |||
| "doctrine/coding-standard": "~0.1@dev" | |||
There was a problem hiding this comment.
must be a dev requirement. We don't want to install it in each project using the package
There was a problem hiding this comment.
Thanks a lot. Put it here by mistake - sure it's only dev requirement.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[resolves #102 ] Doctrine ORM CONTRIBUTING.md changed to collections context.