Require PHP 7.1 #119
Merged
Require PHP 7.1 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are void and shouldn't return anything.
|
@lcobucci how about |
|
@malukenho I like the idea but I rather add it on the major release (along with the type-hints everywhere)... |
|
Strict types can indeed only be added later in a major version. Checking just the current diff, some upcasts may happen for asc/desc ordering, and that means that it would crash hard on people not strictly passing strings to the API. |
Ocramius
approved these changes
May 23, 2017
|
|
soullivaneuh
added a commit
to soullivaneuh/doctrine-collections
that referenced
this pull request
Jun 26, 2017
7.1 is required since doctrine#119, but composer was not updated.
|
FYI: See #125 for strict types, etc. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to doctrine/orm#6425