Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted the docblocks of ArrayCollection to short type hints #126

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Converted the docblocks of ArrayCollection to short type hints #126

merged 2 commits into from
Jul 21, 2017

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Jul 16, 2017

What the title says.

But also I need to make a question here. Since you bumbed to php7.1 why you haven't used return types for the functions?

@Majkl578
Copy link
Contributor

Since you bumbed to php7.1 why you haven't used return types for the functions?

Because adding return types would be a BC break. But I think you'd like #125. 😎

@Ocramius Ocramius added this to the 1.5 milestone Jul 21, 2017
@Ocramius Ocramius self-assigned this Jul 21, 2017
Ocramius
Ocramius approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Ocramius Ocramius merged commit fafd879 into doctrine:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gmponos @Majkl578 @Ocramius