Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect that ExpressionBuilder#andX() and orX() params are variadic in PHPDoc #218

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

someniatko
Copy link
Contributor

Like #217 but changes only PHPDoc

@someniatko someniatko force-pushed the 1.6-eb-variadic-docs-only branch from 5eb9f94 to 6ac157e Compare November 13, 2019 12:20
@someniatko someniatko changed the base branch from master to 1.6.x November 13, 2019 12:21
@someniatko
Copy link
Contributor Author

force-pushed to change commit author

@alcaeus alcaeus requested a review from Ocramius November 13, 2019 12:31
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CI doesn't seem to be picking this up though

@alcaeus
Copy link
Member

alcaeus commented Nov 13, 2019

@Ocramius sometimes GitHub and Travis-ci just need a gentle kick in the right direction ;)

@Ocramius Ocramius self-assigned this Nov 13, 2019
@Ocramius Ocramius merged commit 6b1e4b2 into doctrine:1.6.x Nov 13, 2019
@Ocramius Ocramius changed the title reflect that ExpressionBuilder#andX() and orX() params are variadic in PHPDoc reflect that ExpressionBuilder#andX() and orX() params are variadic in PHPDoc Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants