Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat closure type in Collection #411

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

VincentLanglet
Copy link
Contributor

Hi, @greg0ire @derrabus

psalm is loosing the other param type when half of the phpdoc is repeated.
Cf vimeo/psalm#5776

So we have to repeat the whole phpdoc to get the Closure analysis.

@greg0ire
Copy link
Member

Consider adding a test such as in https://github.com/doctrine/orm/tree/3.1.x/tests/StaticAnalysis, that would fail without your change, so that it does not get removed.

@VincentLanglet
Copy link
Contributor Author

Consider adding a test such as in doctrine/orm@3.1.x/tests/StaticAnalysis, that would fail without your change, so that it does not get removed.

Done

@greg0ire greg0ire added this to the 2.2.2 milestone Apr 18, 2024
@greg0ire greg0ire merged commit d8af7f2 into doctrine:2.2.x Apr 18, 2024
6 checks passed
@greg0ire
Copy link
Member

Thanks @VincentLanglet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants