Arraycollection matching method multiple ordering fix #64
Conversation
Reverts changes made in: 5c07550
| array('foo' => 2, 'bar' => 3) | ||
| )); | ||
|
|
||
| $expected = [ |
There was a problem hiding this comment.
this is not compatible with PHP 5.3, which is still supported
There was a problem hiding this comment.
Sorry, missed that short array syntax.
|
@stof Fixed php 5.3 support issues(array short syntax). |
|
👍 |
|
@Ocramius it would be great to merge this bugfix and to release 1.3.1 |
|
@stof Do you know where we are with merging this? |
|
@stof Any news about this PR ? |
…multiple-ordering-fix Arraycollection matching method multiple ordering fix
|
Thanks! Tagging is up to @Ocramius though. |
|
@Ocramius Any news on tagging a new release including this fix? Thank you. |
|
Also having this issue |
|
@Ocramius : +1 for a 1.3.1 |
|
Sooo... how 'bout that 1.3.1? Or is this project no longer maintained? |
|
We should tag a 1.4 version soon... =) |
|
Likely going to work on these repos after DPC, which is at the end of the month. |
|
Could we maybe get a new release including this? |
|
@trickeyone Done |
|
@mikeSimonson what am I supposed to do here? |
|
@deeky666 nothing, but you merge the PR so it was assigned to you. I taught that it was the new ™️ policy |
|
@mikeSimonson you are right I did indeed :D Didn't remember. Thanks. |
This is a copy of #59 that includes unit tests.