implement ExpressionBuilder->memberOf() method

[ferjul17]

Hi,

The comparison MEMBER_OF was not implemented on Cretieria while it seems really easy to implement.
I implemented it and wrote the test.
I also tested it in my application.

[baileylo]

The parameter order seems a little odd to me. I'm assuming, the value parameter comes first to make the code more readable, ->memberOf('photography', 'hobbies') could be read 'photography is a member of hobbies. However, every other method has the reversed parameter order -->memberOf('hobbies', 'photography')`.

Also, The code fails if the nested value is an array.

$collection = new ArrayCollection([
    ['name' => 'Bill', 'hobbies' => ['biking', 'running', 'swimming']],
    ['name' => 'Todd', 'hobbies' => ['video games', 'laser tag']],
    ['name' => 'Casey', 'hobbies' => ['tennis', 'golf', 'photography']]
]);

$criteria = Criteria::create()->where(Criteria::expr()->memberOf('photography', 'hobbies'));

$collection->matching($criteria)->toArray();

[ferjul17]

Thanks for your feedback.

As you said I inverted the parameters in order to make it more readable because in my opinion this is the most important thing. But changing the order of the parameter takes about 2s with my IDE.

I fixed my code. Unfortunatly, it is not as beautifull as the rest of the code because I can not use the in_array function.

[mikeSimonson]

@ferjul17 Why can't you use in_array here ?

[ferjul17]

@mikeSimonson ClosureExpressionVisitor::getObjectFieldValue may return an instance of Iterator which doesn't work with in_array.

[mikeSimonson]

Maybe using iterator_to_array and then in_arrau is a little bit cleaner ?

[ferjul17]

Would you prefer something like that ?

[mikeSimonson]

@ferjul17 Thanks

[ferjul17]

You're welcome :)

2016-03-27 19:00 GMT+02:00 mikeSimonson notifications@github.com:

@ferjul17 https://github.com/ferjul17 Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#66 (comment)