Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide forward-compat replace for doctrine/{event-manager,persistence,reflection} #843

Closed
wants to merge 1 commit into from

Conversation

Majkl578
Copy link
Contributor

This should allow us to depend on doctrine/event-manager package while still using doctrine/common 2.8.x (thus not requiring immediate release of 2.9, which should be done once we solve doctrine/persistence).
This is targetting 2.8 only, not applicable in 2.9.x-dev (#842 will be done instead).
Once doctrine/common 2.9.0 is out, real dependency kicks in.

@Ocramius Does this make sense as forward compatible polyfill? doctrine/event-manager is identical.

@Majkl578 Majkl578 added this to the 2.8.2 milestone Jun 11, 2018
@Majkl578
Copy link
Contributor Author

Hmm, not sure if this is gonna work. 🤔

@Majkl578
Copy link
Contributor Author

Did some testing locally and it seems fine. 👍 Let's wait for @Ocramius to possibly spot some dragons.

@Ocramius
Copy link
Member

Hmm. @Majkl578, did you also check "provides"? Other than that, this seems to be the correct usage of "replace", but "replace" shouldn't need "conflict". This will likely need to be manually tested against a local satis installation before we push it and cause some issues downstream.

@Majkl578
Copy link
Contributor Author

I tried provide but it didn't seem to work as expected, maybe I just did something wrong.

"replace" shouldn't need "conflict"

Hmm, that's to avoid 1.1-2.0 simultaneously which could, according to semver, contain some new features that Common wil no longer be able to provide.

This will likely need to be manually tested against a local satis installation before we push it and cause some issues downstream.

Agreed, anyone volunteers for the job? 😊
Alternatively we can just ship Common 2.9.0 with no features, just separated EvM (and leave Persistence for 2.10).

@stof
Copy link
Member

stof commented Jun 14, 2018

@Majkl578 replace already means provide+conflict

@stof
Copy link
Member

stof commented Jun 14, 2018

Alternatively we can just ship Common 2.9.0 with no features, just separated EvM (and leave Persistence for 2.10).

that might be much easier actually. Version numbers are free. Releasing 2.8.2 and 2.9.0 or 2.9.0 and 2.10.0 is not that different (we use semver ranges in projects depending on doctrine/common anyway)

@Majkl578 Majkl578 changed the title Provide forward-compat replace for doctrine/event-manager Provide forward-compat replace for doctrine/{event-manager,persistence,reflection} Jun 20, 2018
@Majkl578
Copy link
Contributor Author

Updated to also include doctrine/persistence and doctrine/reflection.

2.9.0 will not include any of these three packages.

@stof
Copy link
Member

stof commented Jun 21, 2018

AFAIK, these 3 packages are ready. So I'd rather release them and move forward to 2.9.0 already, without messing up with replace rules here. It will be simpler.

@Majkl578
Copy link
Contributor Author

Yes, the plan is to release 2.9.0 in upcoming days (once #845 is resolved) and then, should there be some issues with upgrading (i.e. some combinations like DBAL 2.8 + ORM 2.6 + Symfony 3.x), we can consider this PR. For now I'll leave it open and we'll see.

@Majkl578
Copy link
Contributor Author

I think the transition in 2.9.0 went well and without any major issues, so this can now be closed.

@Majkl578 Majkl578 closed this Sep 21, 2018
@Majkl578 Majkl578 removed this from the 2.8.2 milestone Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants