Merge pull request #4153 from morozov/remove-deprecated

Remove deprecated components

UPGRADE.md

@@ -1,5 +1,12 @@
 # Upgrade to 3.0
 
+## BC BREAK: Removed DBALException factory methods
+
+The following factory methods of the DBALException class have been removed:
+
+1. `DBALException::invalidPlatformSpecified()`.
+2. `DBALException::invalidPdoInstance()`.
+
 ## BC BREAK: PDO-based driver classes are moved under the PDO namespace
 
 The following classes have been renamed:
@@ -134,6 +141,7 @@ The `Doctrine\DBAL\Driver::getName()` has been removed.
  * Removed `MysqlSessionInit` listener.
  * Removed `MysqlPlatform::getCollationFieldDeclaration()`.
  * Removed `AbstractPlatform::getIdentityColumnNullInsertSQL()`.
+ * Removed `AbstractPlatform::fixSchemaElementName()`.
  * Removed `Table::addUnnamedForeignKeyConstraint()` and `Table::addNamedForeignKeyConstraint()`.
  * Removed `Table::renameColumn()`.
  * Removed `SQLParserUtils::getPlaceholderPositions()`.

src/DBALException.php

@@ -28,16 +28,6 @@ public static function notSupported($method)
         return new self(sprintf("Operation '%s' is not supported by platform.", $method));
     }
 
-    /**
-     * @deprecated Use {@link invalidPlatformType()} instead.
-     */
-    public static function invalidPlatformSpecified(): self
-    {
-        return new self(
-            "Invalid 'platform' option specified, need to give an instance of " . AbstractPlatform::class . '.'
-        );
-    }
-
     /**
      * @param mixed $invalidPlatform
      */
@@ -82,19 +72,6 @@ public static function invalidPlatformVersionSpecified($version, $expectedFormat
         );
     }
 
-    /**
-     * @deprecated Passing a PDO instance in connection parameters is deprecated.
-     *
-     * @return DBALException
-     */
-    public static function invalidPdoInstance()
-    {
-        return new self(
-            "The 'pdo' option was used in DriverManager::getConnection() but no " .
-            'instance of PDO was given.'
-        );
-    }
-
     /**
      * @param string|null $url The URL that was provided in the connection parameters (if any).
      *

src/Platforms/AbstractPlatform.php

@@ -3380,21 +3380,6 @@ public function getSQLResultCasing($column)
         return $column;
     }
 
-    /**
-     * Makes any fixes to a name of a schema element (table, sequence, ...) that are required
-     * by restrictions of the platform, like a maximum length.
-     *
-     * @deprecated
-     *
-     * @param string $schemaElementName
-     *
-     * @return string
-     */
-    public function fixSchemaElementName($schemaElementName)
-    {
-        return $schemaElementName;
-    }
-
     /**
      * Maximum length of any given database identifier, like tables or column names.
      *

src/Platforms/OraclePlatform.php

@@ -1088,21 +1088,6 @@ public function getTimeFormatString()
         return '1900-01-01 H:i:s';
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @deprecated
-     */
-    public function fixSchemaElementName($schemaElementName)
-    {
-        if (strlen($schemaElementName) > 30) {
-            // Trim it
-            return substr($schemaElementName, 0, 30);
-        }
-
-        return $schemaElementName;
-    }
-
     /**
      * {@inheritDoc}
      */