MySqlPlatform::getListTableColumnsSQL() is not escaping names

[sadortun]

Hi !

When creating by accident a table that contain a \ in the name, abc\ The migration fail to read and escape correctly the table names.

$ php app/console oro:platform:update --env dev --force
Process migrations...

[Doctrine\DBAL\Exception\SyntaxErrorException]
An exception occurred while executing 'SELECT COLUMN_NAME AS Field, COLUMN_TYPE AS Type, IS_NULLABLE AS `Null`, COLUMN_KEY AS `Key`, COLUMN_DEFAULT AS `Default`, EXTRA
 AS E  xtra, COLUMN_COMMENT AS Comment, CHARACTER_SET_NAME AS CharacterSet,  OLLATION_NAME AS Collation FROM information_schema.COLUMNS WHERE TABLE_SCHEMA = 'asdf' AND TABLE   _NAME = ''abc\'':

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the ri
ght syntax to use near ''oro_tag_taxonomy\'' at line 1

[Deltachaos]

@sadortun i think this has todo with the behaivor of the quote strategy which is not escaping reserved fieldnames per default. This behaivor may change due to doctrine/orm#5903.
Beside that i think migrations are a feature of the ORM.

Or i am wrong @Majkl578 @deeky666 ?

[sadortun]

@Deltachaos Thanks. Please me know if you believe it's an internal issue, or an issue with the library client. If it's the case i'll re-open the bug on their side

[deeky666]

This is an edge that has to be dealt with in DBAL. This is not about reserved keywords but about escape characters in column names passed into the metadata SQL (it seems).

[deeky666]

Fix supplied in #2442

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.