Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testSettingUnknownOptionIsStillSupported() is reported as risky. #3075

Closed
morozov opened this issue Mar 31, 2018 · 4 comments
Closed

testSettingUnknownOptionIsStillSupported() is reported as risky. #3075

morozov opened this issue Mar 31, 2018 · 4 comments
Labels
CI Failing Test

Comments

@morozov
Copy link
Member

morozov commented Mar 31, 2018

In some cases, testSettingUnknownOptionIsStillSupported() is reported as risky:

There was 1 risky test:

  1. Doctrine\Tests\DBAL\Schema\ColumnTest::testSettingUnknownOptionIsStillSupported
    This test did not perform any assertions
    ...
    Legacy deprecation notices (1)
@morozov
Copy link
Member Author

morozov commented Mar 31, 2018

@greg0ire, mind taking a look?

@greg0ire
Copy link
Member

AFK this we, but I can try it from my phone :P

greg0ire added a commit to greg0ire/dbal that referenced this issue Apr 2, 2018
@greg0ire
Use phpunit bridge ^4.0.6
157ec23 
Old versions report annotation assertions as risky.
Fixes doctrine#3075
@Majkl578
Copy link
Contributor

Majkl578 commented Apr 7, 2018

Should be fixed by #3090 + #3095.

@Majkl578 Majkl578 closed this as completed Apr 7, 2018
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CI Failing Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morozov @Majkl578 @greg0ire