OCI8Statement::execute() ignores binding errors

[morozov]

Q	A
BC Break	no
Version	2.8.0

Statement::bind*() methods return a boolean value to indicate whether the binding was successful:

dbal/lib/Doctrine/DBAL/Driver/Statement.php

Lines 51 to 53 in df43437

	* @return bool TRUE on success or FALSE on failure.
	*/
	public function bindValue($param, $value, $type = ParameterType::STRING);

This value is ignored in other DBAL components. For instance:

dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php

Lines 391 to 394 in 2ec1743

	if ($hasZeroIndex && is_numeric($key)) {
	$this->bindValue($key + 1, $val);
	} else {
	$this->bindValue($key, $val);

It leads to the issues like:

use Doctrine\DBAL\DriverManager;

$conn = DriverManager::getConnection([
    'driver' => 'oci8',
    'host' => 'localhost',
    'user' => 'system',
    'password' => 'oracle',
    'dbname' => 'XE',
]);

$data = $conn->fetchAll('SELECT 1 FROM DUAL', [123]);

var_dump($data);

/*
Warning: oci_bind_by_name(): ORA-01036: illegal variable name/number in lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php on line 316

array(1) {
  [0] =>
  array(1) {
    [1] =>
    string(1) "1"
  }
}
*/

Statement::execute() should throw an exception in the case of a binding error instead of trying to execute an incorrectly constructed query.

[Ocramius]

Handled in #3369

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.