Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute() #3369

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 1, 2018

Q A
Type improvement
BC Break no
Fixed issues #3366
  1. MysqliStatement: regardless of whether the underlying statement has bound variables, try binding the parameters passed to the DBAL statement to get them validated by the driver.
  2. OCI8Statement: do not ignore the return value of oci_bind_by_name().

UPGRADE.md Show resolved Hide resolved
tests/Doctrine/Tests/DBAL/Functional/StatementTest.php Outdated Show resolved Hide resolved
@morozov morozov changed the base branch from master to develop December 1, 2018 22:01
@morozov
Copy link
Member Author

morozov commented Dec 1, 2018

@Ocramius, retargeted.

@Ocramius Ocramius self-assigned this Dec 1, 2018
@Ocramius Ocramius added this to the 3.0.0 milestone Dec 1, 2018
@Ocramius
Copy link
Member

Ocramius commented Dec 1, 2018

🚢

@Ocramius Ocramius merged commit 7764294 into doctrine:develop Dec 1, 2018
@morozov morozov deleted the issues/3366 branch December 2, 2018 00:17
morozov pushed a commit that referenced this pull request Dec 6, 2018
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
morozov pushed a commit that referenced this pull request Jan 20, 2019
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
morozov pushed a commit to morozov/dbal that referenced this pull request Feb 6, 2019
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants