[WIP] [DBAL-216] Add Sqlsrv as driver #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated DateTime instances.
| { | ||
| public function connect(array $params, $username = null, $password = null, array $driverOptions = array()) | ||
| { | ||
| return new Connection( |
There was a problem hiding this comment.
this seems wrong. The class does not exist
This is necessary because pdo_sqlsrv still has some little bugs that prevent it from being used in all use-cases. Additionally only sqlsrv can make use of the Azure federations features.
beberlei
added a commit
that referenced
this pull request
Feb 6, 2012
[DBAL-216] Add Sqlsrv as driver
| $fetchStyle = ($fetchStyle)?:$this->defaultFetchStyle; | ||
| if (isset(self::$fetchMap[$fetchStyle])) { | ||
| return sqlsrv_fetch_array($this->stmt, self::$fetchMap[$fetchStyle]); | ||
| } else if ($fetchStyle == PDO::FETCH_OBJ || $fetchStyle == PDO::FETCH_CLASS) { |
There was a problem hiding this comment.
you don't need else here and below as each if block returns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/sqlsrv has some benefits over using pdo_sqlsrv such as advanced Azure Platform featuers.