Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionBuilder in and notIn methods #192

Merged
merged 3 commits into from
Aug 29, 2012
Merged

Conversation

paulchubatyy
Copy link
Contributor

ExpressionBuilder is missing in and not in methods to produce these statements.

@travisbot
Copy link

This pull request fails (merged aa4f09c into bb88ba7).

@travisbot
Copy link

This pull request fails (merged aa4f09c into bb88ba7).

@stof
Copy link
Member

stof commented Aug 27, 2012

Please run your own tests when adding them :)

@paulchubatyy
Copy link
Contributor Author

My bad, didn't have the environment set up completely on the new workstation.

@travisbot
Copy link

This pull request passes (merged 802109c into bb88ba7).

@stof
Copy link
Member

stof commented Aug 28, 2012

Please revert the permission changes. These files have no reason to be executable.

If you are on windows, you should configure git to ignore the file mode as windows does not have filemode properly and so messes it

@paulchubatyy
Copy link
Contributor Author

@stof, thanks, didn't know how to fix that issue with file modes. And you're right, I'm currently on windows with cygwin so it drives me nuts.

@travisbot
Copy link

This pull request passes (merged f812cc8 into bb88ba7).

beberlei added a commit that referenced this pull request Aug 29, 2012
ExpressionBuilder in and notIn methods
@beberlei beberlei merged commit 3965d4f into doctrine:master Aug 29, 2012
@paulchubatyy
Copy link
Contributor Author

@beberlei this might be also backported to previous doctrine dbal versions.

@stof
Copy link
Member

stof commented Sep 13, 2012

@Xobb new features are not backported. This is the difference between minor releases and maintenance releases which only receive bugfixes

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants