Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params not passed from execute to logger #200

Merged
merged 4 commits into from
Sep 17, 2012
Merged

params not passed from execute to logger #200

merged 4 commits into from
Sep 17, 2012

Conversation

robap
Copy link
Contributor

@robap robap commented Sep 16, 2012

When parameters are passed to Doctrine\DBAL\Statement::execute, they are not passed to any enabled logger(s).

use Doctrine\DBAL\Statement;
//use Doctrine\Common\EventManager;
//use Doctrine\DBAL\Configuration;
//use Doctrine\DBAL\Events;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these commented use statements

@@ -129,6 +129,10 @@ public function bindParam($name, &$var, $type = PDO::PARAM_STR, $length = null)
*/
public function execute($params = null)
{
if(is_array($params)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between if and open parenthesis

beberlei added a commit that referenced this pull request Sep 17, 2012
params not passed from execute to logger
@beberlei beberlei merged commit a012705 into doctrine:master Sep 17, 2012
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants