MySql TEXT and BLOB type declarations #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2012 20:45
This should be 65535 (2 ^ 16 - 1) in stead of 65532. Modified docblock to show the max lengths.
Choose between TINYBLOB, BLOB, MEDIUMBLOB and LONGBLOB based on the length of the field. Behaves the same way as the TEXT type declaration.
Conflicts: tests/Doctrine/Tests/DBAL/Platforms/MySqlPlatformTest.php
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
| @@ -9,6 +9,8 @@ | |||
| use Doctrine\DBAL\Schema\Schema; | |||
| use Doctrine\DBAL\Schema\Index; | |||
|
|
|||
| require_once __DIR__ . '/../../TestInit.php'; | |||
There was a problem hiding this comment.
This should be removed. It is not needed
|
Can you replace all those magic numbers with contstants please? |
|
I rebased and merged this branch here: Thanks! |
|
Thanx for updating the code for me! PS: I would have gone with constants like |
|
Changes Unknown when pulling 39bc14a on jaspernbrouwer:master into * on doctrine:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed maximum length of MySql TEXT type declaration, this should be 65535 (2 ^ 16 - 1) in stead of 65532.
Added support for TINYBLOB, BLOB, MEDIUMBLOB and LONGBLOB based on the length of the field, the same way as the clob type declarations are determined.
Added tests to prevent regression.