Fix OFFSET without LIMIT cause MySQL syntax error. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
@Everus what's the failing test case for this one? |
|
This is wrong. It does not add the offset anymore when the limit is not null |
|
I can't see what wrong in it, maybe you can point me in right direction. |
|
hmm, sorry. However, as this fix is only for MySQL, I think it should be done in the MySQLPlatform only |
|
Fixed in 3f220a1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL OFFSET require LIMIT.
So fixed it to use the biggest limit possible as it recommended in http://dev.mysql.com/doc/refman/5.0/en/select.html#id4651990