added the possibility to use column names as keys for the types in Connection::insert() #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
could you add a unit test for this ? Otherwise, I'm +1 for this. I also expected the column name to work when I saw it. And please implement it also for |
…nnection insert() and update() methods
The Connection::insert() and Connection::update() methods take an array
of types as their third argument:
$conn->insert('foo', array('foo' => 'foo', 'date' => new \DateTime()),
array(2 => 'datetime'));
But without looking at the implementation, I'm sure you would have
written the following instead:
$conn->insert('foo', array('foo' => 'foo', 'date' => new \DateTime()),
array('date' => 'datetime'));
But unfortunately, that's does not work. This commit add support for
this, and of course, the old way still works.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Connection::insert() method takes an array of types as its third argument:
But without looking at the implementation, I'm sure you would have written the following instead:
But unfortunately, that's does not work. This commit add support for this, and of course, the old way still works.