Remove inconsistencies in table/column escaping for mysql #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent future bugs with reserved keywords)
Anything we can do to assess that? A regression prevention test? |
|
Was hypothetical ;) Anyway quoting table and columns with '`' (which was 50% done) would give some guarantee. But not very important anyway... Feel free to close the P/R, I don't feel urgency to work on this (just added while discovering the code to fix #2825) |
|
@belgattitude the reasoning is quite simple: I need a test that justifies a change in the code. I'd rather have this fail with new MySQL versions (with existing tests) than a change now with no evidence of failure. |
|
@Ocramius thanks I understand. I'll close this one. Keep the good work :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might prevent possible future bugs with reserved keywords.