Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use newer PHP syntax #2856

Merged
merged 1 commit into from
Sep 11, 2017
Merged

use newer PHP syntax #2856

merged 1 commit into from
Sep 11, 2017

Conversation

AlessandroMinoccheri
Copy link
Contributor

No description provided.

@Ocramius Ocramius self-assigned this Sep 11, 2017
@Ocramius Ocramius added this to the 2.7 milestone Sep 11, 2017
@Ocramius
Copy link
Member

LGTM 👍

@Ocramius Ocramius merged commit be3478e into doctrine:master Sep 11, 2017
@Majkl578
Copy link
Contributor

(I was just wondering... Why did you left out Configuration classes with the sameisset constructs?)

@AlessandroMinoccheri
Copy link
Contributor Author

AlessandroMinoccheri commented Sep 11, 2017 •
edited
Loading

Ops, I haven't find those because are in two lines and my parser didn't find them.
I open a new PR with the fix ok? @Majkl578

@AlessandroMinoccheri AlessandroMinoccheri deleted the new_php_syntax branch September 11, 2017 14:07
@lcobucci
Copy link
Member

I open a new PR with the fix ok? @Majkl578

yes, please 😄

@Majkl578
Copy link
Contributor

I open a new PR with the fix ok?

That'd be great, don't consider it a fix, rather an improvement. :)

@AlessandroMinoccheri
Copy link
Contributor Author

yeah you have again right @Majkl578 :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlessandroMinoccheri @Ocramius @Majkl578 @lcobucci