Style improvements #2858
Merged
Style improvements #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
suggested changes
Sep 11, 2017
|
|
||
| $this->assertEquals( | ||
| ' DEFAULT '.$currentDateSql, | ||
| $this->assertSame( |
| @@ -563,16 +563,16 @@ public function testGetDefaultValueDeclarationSQLForIntegerTypes() | |||
| } | |||
| } | |||
|
|
|||
| public function testGetDefaultValueDeclarationSQLForDateType() | |||
| public function testGetDefaultValueDeclarationSQLForDateType(): void | |||
greg0ire
force-pushed
the
style_improvements
branch
from
ea9fa73
to
e63cd3d
Compare
|
Does Doctrine have a coding standard about concatenation of strings with |
|
Spaces
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
…On Tue, Sep 12, 2017 at 11:20 AM, Claudio Zizza ***@***.***> wrote:
Does Doctrine have a coding standard about concatenation of strings with .?
Spaces or no spaces?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2858 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakP-qMekV-7RQUvw8V8n-cWP4Ei_Iks5shkz4gaJpZM4PTk9f>
.
|
|
I have nothing to add here. 👍 |
|
@SenseException you can see more info on https://github.com/doctrine/coding-standard |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the mess I introduced in #2835 and #2851
@SenseException @lcobucci please review preferrably before this gets merged :P