Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statement objects should throw exception in exceptional cases #3154

Closed
wants to merge 1 commit into from
Closed

Statement objects should throw exception in exceptional cases #3154

wants to merge 1 commit into from

Conversation

morozov
Copy link
Member

@morozov morozov commented May 17, 2018 •
edited
Loading

Q A
Type improvement
BC Break yes
Fixed issues #3005

Summary

TBD

@morozov morozov self-assigned this May 17, 2018
@morozov morozov force-pushed the develop branch 2 times, most recently from 72cddfb to d8f1786 Compare June 6, 2018 21:46
@morozov morozov force-pushed the develop branch 3 times, most recently from 67bd64c to 7e5fb71 Compare July 2, 2018 00:52
@morozov morozov mentioned this pull request Jul 11, 2018
Closed
@morozov morozov mentioned this pull request Aug 31, 2018
Merged
@morozov morozov force-pushed the develop branch 2 times, most recently from c4478a0 to e5a586e Compare October 7, 2018 22:01
@morozov morozov mentioned this pull request Nov 2, 2018
Closed
@morozov morozov force-pushed the develop branch 2 times, most recently from 0a11c71 to fa42c10 Compare November 14, 2018 19:23
@morozov morozov mentioned this pull request Nov 16, 2018
Closed
@morozov morozov force-pushed the develop branch 2 times, most recently from 3850154 to 4fbe91a Compare February 22, 2019 00:01
@morozov morozov mentioned this pull request Feb 23, 2019
Merged
@morozov morozov force-pushed the develop branch 2 times, most recently from 322dc7c to 56546b9 Compare March 15, 2019 16:46
@morozov
Copy link
Member Author

morozov commented Apr 9, 2019

Closing for now. It's fixed partially by #3486. The other issues, e.g. fetching from a non-executed statement may be resolved better by separating the Statement and Result APIs.

@morozov morozov closed this Apr 9, 2019
@morozov morozov deleted the issues/3005 branch April 9, 2019 00:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@morozov morozov

Labels
BC Break Improvement Prepared Statements WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@morozov