Fixed and suppressed issues found by PHPStan on develop

[morozov]

Q	A
Type	improvement
BC Break	no
Fixed issues	none

As of #3025, the develop builds fail due to the issues which didn't exist and weren't fixed in master.

#3236 and #3237 have been separately filed as release blockers for 3.0 since fixing them requires a deeper understanding of the underlying issues than I currently have.

[morozov]

@Majkl578 while I understand the PHPStan's inability to use stubbed PDO::SQLSRV_* constants, what's the reason we should white-list this method? As long as pdo_sqlite is loaded on Travis, shouldn't PHPStan be able to see it via the extension reflection?

[Majkl578]

As long as pdo_sqlite is loaded

Exactly, as long as it is loaded. And pdo_sqlite is not direct dependency in composer.json, so you may not have it enabled locally. And polyfills can't add methods/constants to existing classes.
Maybe we should have two phpstan configs with specific ignores for Travis.

[Majkl578]

This is als why I disabled reportUnmatchedIgnoredErrors, since different people/environments have different extensions.

[morozov]

Gotcha. I thought this issue was reproducible despite whether pdo_sqlite was loaded or not.

The necessity to use reportUnmatchedIgnoredErrors() across the board and the fact that PHP extensions can add members to existing classes (which is impossible in PHP) looks like a ground for PHPStan to implement this "extensibility" feature for stubs as well. I.e. it should initialize from the extension reflection and then merge the stubbed symbols in. Does it sound like a reasonable feature request?

[Ocramius]

👍