Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted strict comparison back to loose because of a new regression #3382

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Reverted strict comparison back to loose because of a new regression #3382

merged 2 commits into from
Dec 5, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 4, 2018

Q A
Type bug
BC Break no
Fixed issues #3377

Reverted strict comparison back to loose.

@morozov morozov added this to the 2.9.1 milestone Dec 4, 2018
Ocramius
Ocramius previously approved these changes Dec 4, 2018
View reviewed changes
lcobucci
lcobucci previously approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some thoughts

tests/Doctrine/Tests/DBAL/Functional/Schema/ComparatorTest.php Outdated Show resolved Hide resolved
tests/Doctrine/Tests/DBAL/Functional/Schema/ComparatorTest.php Show resolved Hide resolved
lib/Doctrine/DBAL/Schema/OracleSchemaManager.php Outdated Show resolved Hide resolved
@lcobucci lcobucci self-assigned this Dec 5, 2018
@lcobucci lcobucci merged commit e40e959 into doctrine:master Dec 5, 2018
@lcobucci
Copy link
Member

lcobucci commented Dec 5, 2018

@morozov 🚢

@Ocramius Ocramius mentioned this pull request Dec 5, 2018
Closed
@morozov morozov deleted the issues/3377 branch December 5, 2018 17:54
morozov added a commit that referenced this pull request Dec 5, 2018
@morozov
Merge branch 'bpo/2.9/#3382' into 2.9
f8e32cc
@morozov morozov mentioned this pull request Mar 23, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Majkl578 Majkl578 Majkl578 left review comments

@lcobucci lcobucci lcobucci approved these changes

@Ocramius Ocramius Ocramius left review comments

Assignees

@lcobucci lcobucci

Labels
Bug Regression Schema Comparison Types
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@morozov @lcobucci @Majkl578 @Ocramius