Fix unquoted stmt fragments backslash escaping #3772
Conversation
"Cannot find path 'C:\tools\php' because it does not exist" seems unrelated :) |
There was a problem hiding this comment.
@ChristophWurst the patch looks good. While the existing tests look weird: why would anyone want to escape using a double slash? The SQL syntax explicitly states that it should be a character, not a string.
|
Could you try rebasing and see if the build gets fixed? Otherwise, I'll have to change the repository settings in order to be able to merge the PR. |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
No worries. Squashed it :) |
ChristophWurst
deleted the
fix/get-unquoted-stmt-fragments-escape-backslash
branch
|
Hey @morozov, sorry for poking in this closed PR but can we backport this fix to the older versions 2.9 or 2.10? I couldn't find the docs about your backporting process and/or guidelines. Shall I open a ticket? |
|
@ChristophWurst see the list of supported versions on the website. I can backport it to |
|
Got it. Thanks for the quick answer! |
Fix unquoted stmt fragments backslash escaping
Summary
See #3640. A backslash in a literal wasn't detect by the statement parser and it thus failed to find the position of placeholders.
This is based on and supersedes #3641 with the new test case.