Removed the OCI8Connection::getExecuteMode() method #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Jan 3, 2020
|
The ContinuousPHP build currently fails due to the issue being addressed by #3809. |
beberlei
previously approved these changes
Jan 8, 2020
6 tasks
morozov
force-pushed
the
remove-oci8-connection-execute-mode
branch
2 times, most recently
from
4d81e5d
to
b6ca7e7
Compare
The existing relationship between the connection and its statement violate the ISP principle. Instead of having access only to the execution mode of the connection, statements have access to the entire connection API. Having a method which is not defined in the driver connection interface makes it impossible to mark the method `final` (doctrine#3590).
morozov
force-pushed
the
remove-oci8-connection-execute-mode
branch
from
b6ca7e7
to
a0ff364
Compare
Ocramius
suggested changes
Jan 13, 2020
Ocramius
approved these changes
Jan 13, 2020
This was referenced Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing relationship between the connection and its statement violate the ISP principle. Instead of having access only to the execution mode of the connection, statements have access to the entire connection API.
Having a method which is not defined in the driver connection interface makes it impossible to mark the method
final(#3590).Summary