Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow php 8 #4028

Merged
merged 1 commit into from
May 26, 2020
Merged

Allow php 8 #4028

merged 1 commit into from
May 26, 2020

Conversation

greg0ire
Copy link
Member

Targeting 3.0.x on that particular one, because there will never be support for php 8 on 2.x (right?)

SenseException
SenseException requested changes May 25, 2020
View reviewed changes
composer.json.orig Outdated
{"name": "Jonathan Wage", "email": "jonwage@gmail.com"}
],
"require": {
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops indeed 😅

@morozov
Copy link
Member

morozov commented May 26, 2020

Targeting 3.0.x on that particular one, because there will never be support for php 8 on 2.x (right?)

Right. Support for PHP 8 requires a breaking change.

morozov
morozov reviewed May 26, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
morozov
morozov reviewed May 26, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@greg0ire
Copy link
Member Author

greg0ire commented May 26, 2020 •
edited
Loading

Sorry, I didn't notice that nightly was already handled here with --ignore-platform-reqs nothing to change besides the version constraint.

@greg0ire greg0ire requested a review from morozov May 26, 2020 17:36
SenseException
SenseException approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some green nightly builds 🕺

@morozov
Copy link
Member

morozov commented May 26, 2020

Should we then remove --ignore-platform-reqs?

@greg0ire
Copy link
Member Author

greg0ire commented May 26, 2020 •
edited
Loading

Should we then remove --ignore-platform-reqs?

We can try replacing that with composer config platform.php 7.4.99, because we still need to fool our own dependencies into thinking this is 8 7. Tell me what you think.

@morozov
Copy link
Member

morozov commented May 26, 2020

because we still need to fool our own dependencies into thinking this is 8

I don't get this. Isn't PHP nightly the PHP 8?

@greg0ire
Copy link
Member Author

Sorry, I meant: into thinking this is 7. Some might not be 8-compatible yet.

@morozov
Copy link
Member

morozov commented May 26, 2020

Okay, not it makes sense.

@greg0ire
Copy link
Member Author

So do we stay with --ignore-platform-reqs, or do we use the above trick?

@morozov
Copy link
Member

morozov commented May 26, 2020

--ignore-platform-reqs seems to be the proper way.

@greg0ire greg0ire merged commit be4332a into doctrine:3.0.x May 26, 2020
@greg0ire greg0ire deleted the php-8 branch May 26, 2020 20:50
@greg0ire greg0ire self-assigned this May 26, 2020
@greg0ire greg0ire added this to the 3.0.0 milestone Jun 7, 2020
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@morozov morozov morozov approved these changes

Assignees

@greg0ire greg0ire

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @morozov @SenseException