Bump Psalm level to 5 #4094
Bump Psalm level to 5 #4094
Conversation
morozov
commented
Jun 20, 2020
morozov
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
…t the end of connect()
|
|
||
| if ($value === false) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
So we don't consider this a BC-break?
There was a problem hiding this comment.
Yeah, this should be suppressed. I'm not sure if the “BC break” is the right term here because the new value corresponds to the documented return type while the old one didn't.
tests/Doctrine/Tests/DBAL/Functional/Driver/IBMDB2/DB2StatementTest.php
Outdated
Show resolved
Hide resolved
…he test and cannot return NULL
| @@ -95,3 +95,8 @@ parameters: | |||
| message: '~Method Doctrine\\DBAL\\Driver\\PDOSqlsrv\\Connection\:\:lastInsertId\(\) should return string but returns string\|false\|null\.~' | |||
| paths: | |||
| - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOSqlsrv/Connection.php | |||
|
|
|||
| - | |||
| message: '~Method Doctrine\\DBAL\\Portability\\Connection::prepare\(\) should return Doctrine\\DBAL\\Statement but returns Doctrine\\DBAL\\Portability\\Statement\.~' | |||
There was a problem hiding this comment.
This is caused by the issue earlier identified in #4045:
The portability layer is currently implemented on two levels of abstraction at the same time: most of its components implement driver-level interfaces but the
Connectionclass extends the DBAL connection.
|
Thanks @morozov ! |
|
The assertion was done to prove the method contract. It's expected to return a Your use case violates the API. You can define your own implementation (in fact, a mock) of the |
