Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs #4278

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 21, 2020

Q A
BC Break yes
  1. A coding standard violation is fixed (looks introduced by Manually merge 2.11.x into 3.0.x #4275).
  2. DBALException was deprecated in Deprecate DBAL\DBALException in favor of DBAL\Exception #4253.
  3. AbstractPlatform::supportsForeignKeyOnUpdate() is removed. Originally it was removed in Remove deprecated APIs #4234 but then mistakenly reintroduced in Manually merge 2.11.x into 3.0.x #4275.
  4. Back-ported Remove Doctrine\DBAL\Types\Type::getDefaultLength() #3255 from master.

@morozov morozov changed the title Remove DBALException Remove deprecated APIs Sep 21, 2020
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I read somewhere that the CodeCov message only appears on lines with exceptions (technically, you exit the method kinda before reaching its end).

@morozov
Copy link
Member Author

morozov commented Sep 21, 2020

I believe it's just that code is not covered. And in fact dead code as of f580f0a (should be deprecated and removed if not already done in master).

@morozov morozov merged commit 7a5da36 into doctrine:3.0.x Sep 21, 2020
@morozov morozov deleted the remove-dbal-exception branch September 21, 2020 18:36
@morozov morozov self-assigned this Sep 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants