Fix user provided pdo connection

[mdumoulin]

Q	A
Type	bug
BC Break	no
Fixed issues	#4564

Summary

When user provide a PDO connection, we get the following fatal error :

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Doctrine\DBAL\Connection::ensureForwardCompatibilityStatement() must be an instance of Doctrine\DBAL\Driver\ResultStatement, instance of PDOStatement given, called in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 1313 and defined in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1370
Stack trace:
#0 vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(1313): Doctrine\DBAL\Connection->ensureForwardCompatibilityStatement(Object(PDOStatement))
#1 t.php(6): Doctrine\DBAL\Connection->executeQuery('SELECT 1;')
#2 {main}
  thrown in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 1370

It happen because the PDO connection is not wrapped with Driver/Connection Interface in that case. The proposed solution, wrap the PDOStatement with Driver\PDO\Statement.

How to reproduce

<?php                                                                                                                   
require_once('vendor/autoload.php');                                                                                    
                                                                                                                        
$conn = Doctrine\DBAL\DriverManager::getConnection(['pdo' => new PDO('sqlite::memory:'), 'driver' => 'pdo_sqlite']);    
$conn->executeQuery('SELECT 1;');

[morozov]

Thanks, @mdumoulin!

[mdumoulin]

@morozov I'm affraid that the fix here may have side effects. If the user has already wrapped the \PDOStatement, it will be overidden in the DriverManager.

<?php
require_once('vendor/autoload.php');

class MyPDOStatement extends \PDOStatement
{
    public function execute($input_parameters = null)
    {
        var_dump('Hello there');

        return parent::execute($input_parameters);
    }
}

$pdo = new PDO('sqlite::memory:');
$pdo->setAttribute(\PDO::ATTR_STATEMENT_CLASS, [MyPDOStatement::class, []]);

$conn = Doctrine\DBAL\DriverManager::getConnection(['pdo' => $pdo, 'driver' => 'pdo_sqlite']);
$result = $conn->executeQuery('SELECT 1;');
var_dump($result->fetchFirstColumn());