Add explanation why we need to cast float to string in decimal type #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
previously approved these changes
Sep 30, 2021
…nly starting from PHP 8.1
greg0ire
force-pushed
the
decimal-cast-explanation
branch
from
9e70e63
to
d50315e
Compare
auto-merge was automatically disabled
October 2, 2021 14:16
Pull request was closed
greg0ire
approved these changes
Oct 2, 2021
|
Thanks @andrew-demb ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added explanation to code, why we need to cast a float to string only after PHP 8.1
refs: #4818 (comment)
/cc @derrabus