-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Skip type comparison if disableTypeComments is true #6423
Conversation
Can you please add a unit test? |
How do I test this? I tried to understand it by looking at the previous pull request #6150, but I didn't find any tests there. I guess I need to create a Or should I write a test in |
Do you think such a test would be suitable? After reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The place seems appropriate. I don't think you need to create a Comparator
though.
Didn't mean to approve yet, only comment for now, but after the suggested change it should be good
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Thanks, I'm fine with those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @berkut1 ! |
Summary
In the #6150, a check was missed when we were validating the database schema.