Merge 3.8.x up into 4.0.x #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the schema comparison will not remove existing type comments when disabling them because it will still silently remove that part of the comment during introspection (and so won't detect an expected change between the expected empty comment and the introspected comment). Disabling that stripping logic when disabling type comments corresponds to the behavior of DBAL 4 regarding comments, which is exactly what the configuration option is about.
2 things need to change: - the path to the binary, which is now secure by default; - the addition of the -C flag, telling sqlcmd to trust the certificate of the server. Quote from the documentation: > In SQL Server 2022 (16.x) CU 14 and later versions, container images > include the new mssql-tools18 package. The previous directory > /opt/mssql-tools/bin is being phased out. The new directory for > Microsoft ODBC 18 tools is /opt/mssql-tools18/bin, aligning with the > latest tools offering. For more information about changes and security > enhancements, see https://techcommunity.microsoft.com/t5/sql-server-blog/odbc-driver-18-0-for-sql-server-released/ba-p/3169228 See microsoft/mssql-docker#892
Adapt to mssql-docker breaking change
Make the schema manager aware of the disabling of type comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.