Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new docs for the event manager project. #5

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Conversation

jwage
Copy link
Member

@jwage jwage commented Jun 8, 2018

Fixes #4

@jwage jwage added this to the 1.0.0 milestone Jun 8, 2018
@jwage jwage self-assigned this Jun 8, 2018
@jwage jwage added the Documentation A change to the documentation. label Jun 8, 2018
@jwage jwage requested a review from Majkl578 June 8, 2018 01:15
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If this documentation is not helping to answer questions you have about the
Doctrine DBAL, don't panic. You can get help from different sources:

- Gitter chat room `#doctrine/event-manager <https://gitter.im/doctrine/event-manager>`_

This comment was marked as off-topic.

This comment was marked as off-topic.

---------------

The best way to get started is with the :doc:`Introduction <reference/index#introduction>` section
in the documentation. Use the sidebar to browse other documentation for the Doctrine PHP DBAL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: DBAL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the typo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's not DBAL, Its event manager.


public function __construct(EventManager $eventManager)
{
$eventManager->addEventListener(array(self::preFoo, self::postFoo), $this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[] instead of array()


.. code-block:: php

$eventManager->removeEventListener(array(TestEvent::preFoo, TestEvent::postFoo), $testEvent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[] instead of array()


public function getSubscribedEvents() : array
{
return array(TestEvent::preFoo);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[] instead of array()

@jwage jwage merged commit 2606e60 into master Jun 8, 2018
@jwage jwage deleted the event-manager-docs branch June 8, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation A change to the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants