Using the higher entropy uniqid #27
Conversation
| @@ -34,7 +34,7 @@ class InvalidArgumentExceptionTest extends PHPUnit_Framework_TestCase | |||
| { | |||
| public function testFromNonExistingTypeWithNonExistingClass() | |||
| { | |||
| $className = __CLASS__ . uniqid(); | |||
| $className = __CLASS__ . uniqid('', true); | |||
There was a problem hiding this comment.
Can't really work due to . being added to the string
There was a problem hiding this comment.
For my defence the test pass ...
There was a problem hiding this comment.
Yes, but the class name is invalid. Can you add a str_replace around it, please?
There was a problem hiding this comment.
I though I did, did I push ?
There was a problem hiding this comment.
should I do that in the getInvalidClassNames too ?
There was a problem hiding this comment.
Ah, yes, seeing it, although you overwrote the variable: naughty!
mikeSimonson
force-pushed
the
safe-uniqid
branch
from
7692ca3
to
863b2a2
Compare
| @@ -34,7 +34,7 @@ class InvalidArgumentExceptionTest extends PHPUnit_Framework_TestCase | |||
| { | |||
| public function testFromNonExistingTypeWithNonExistingClass() | |||
| { | |||
| $className = __CLASS__ . uniqid(); | |||
| $className = __CLASS__ . uniqid('', true); | |||
There was a problem hiding this comment.
Ah, yes, seeing it, although you overwrote the variable: naughty!
mikeSimonson
force-pushed
the
safe-uniqid
branch
from
863b2a2
to
be726c7
Compare
|
@mikeSimonson we can most probably drop 5.3.3 from the matrix now |
|
We should probably drop all EOL'd versions, tbh - means keeping only 7.0, 7.1 and 7.2 ( |
|
I have done the travis update in another pr. |
No description provided.