replace athletic with phpbench #36
Conversation
bendavies
force-pushed
the
php-bench
branch
4 times, most recently
from
28c4656
to
b93b9c6
Compare
.travis.yml
Outdated
| @@ -7,11 +7,12 @@ php: | |||
| before_script: | |||
| - composer self-update | |||
| - composer update | |||
| - wget https://phpbench.github.io/phpbench/phpbench.phar https://phpbench.github.io/phpbench/phpbench.phar.pubkey | |||
There was a problem hiding this comment.
Please use a composer require step in a separate build pipeline entry
There was a problem hiding this comment.
copied doctrine/doctrine2 here, FYI.
There was a problem hiding this comment.
you prefer to require in the travis step, or in composer.json?
phpbench.json
Outdated
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "bootstrap": "vendor/autoload.php", | |||
phpbench.json
Outdated
| "storage": "dbal", | ||
| "storage.dbal.connection": { | ||
| "driver": "pdo_sqlite", | ||
| "path": "tests/DoctrineTest/InstantiatorPerformance/history.db" |
There was a problem hiding this comment.
Wouldn't store the results unless this is committed to an alternate branch too
bendavies
force-pushed
the
php-bench
branch
7 times, most recently
from
b0117e2
to
b30aed2
Compare
|
@Ocramius should be ok? |
bendavies
force-pushed
the
php-bench
branch
from
b30aed2
to
2f3afb4
Compare
composer.json
Outdated
| "ext-pdo": "*", | ||
| "ext-phar": "*", | ||
| "phpbench/phpbench": "^0.13.0", |
There was a problem hiding this comment.
@bendavies to avoid not seeing different version ranges when installing phpbench or php_codesniffer, I suggest adding an explicit composer require CLI statement in the respective pipeline entries
There was a problem hiding this comment.
@Ocramius do you mean to require a specific version of the deps? e.g. exactly 0.13.0
There was a problem hiding this comment.
No, I mean adding a composer require line to the install step of the .travis.yml build pipeline entries
There was a problem hiding this comment.
done. i'm not sure i know what you mean by to avoid not seeing different version ranges though...
There was a problem hiding this comment.
@bendavies the point is that this lib is to be tested with all possible dependency ranges, so having a lot of dev dependencies means restricting those tested ranges. That's why I asked to move it from require-dev to a CLI command ;-)
bendavies
force-pushed
the
php-bench
branch
from
2f3afb4
to
99e49f6
Compare
bendavies
force-pushed
the
php-bench
branch
from
99e49f6
to
34a5e5d
Compare
|
👍 🚢 Thanks @bendavies! |
🚅