Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter annotation #45

Closed

Conversation

Valouleloup
Copy link

There is no sense to let this annotation if we accept classes that implement InstantiatorInterface with a parameter different than string

@alcaeus
Copy link
Member

alcaeus commented Apr 27, 2018

This is a major BC break for very similar reasons as in #44. I'm closing this as it makes no sense from my point of view, and to consolidate discussion around this in #44.

Even though we don't do scalar types yet, implementations of the interface rely on the docblock to provide implementation guidance and thus only expect string arguments.

@alcaeus alcaeus closed this Apr 27, 2018
@alcaeus alcaeus self-assigned this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants