Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ga #79

Merged
merged 10 commits into from
Nov 10, 2020
Merged

Migrate to ga #79

merged 10 commits into from
Nov 10, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Nov 9, 2020 •
edited
Loading

The result can be seen at greg0ire#1

@greg0ire greg0ire force-pushed the migrate-to-ga branch 7 times, most recently from cd2b084 to ea226ef Compare November 9, 2020 22:03
@greg0ire greg0ire changed the base branch from 1.3.x to 1.4.x November 9, 2020 22:10
@greg0ire greg0ire force-pushed the migrate-to-ga branch 3 times, most recently from b8291d9 to 84d5ea8 Compare November 10, 2020 07:22
@greg0ire greg0ire marked this pull request as ready for review November 10, 2020 08:08
SenseException
SenseException approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you choose 1.4.x as the target branch because of the composer changes in this PR?

@greg0ire
Copy link
Member Author

greg0ire commented Nov 10, 2020 •
edited
Loading

Yes, I made a first attempt to target 1.3.x, then realized I would have to upgrade PHPStan, but that was already done with #77 , and I insisted to target 1.4.x then since that did not fix any bugs and touched src in ways that are more than just CS, but can also make our users' CI pipelines fail. I think having 1.3.2 is not worth it and we can release 1.4.0 directly

@greg0ire greg0ire merged commit d56bf61 into doctrine:1.4.x Nov 10, 2020
@greg0ire greg0ire deleted the migrate-to-ga branch November 10, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException