Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The roave BC check CI is broken #1353

Closed
stof opened this issue Aug 18, 2023 · 0 comments · Fixed by #1354
Closed

The roave BC check CI is broken #1353

stof opened this issue Aug 18, 2023 · 0 comments · Fixed by #1354

Comments

@stof
Copy link
Member

stof commented Aug 18, 2023

See Nyholm/roave-bc-check-docker#32 for the report on the docker image being used to run that step.

According to Nyholm/roave-bc-check-docker#32 (comment), running the tool on the runner itself is also faster, so it might make sense to move away from the action.
greg0ire added a commit to greg0ire/migrations that referenced this issue Aug 18, 2023
@greg0ire
Ditch action in favor of running tool directly
fd0fe06 
Closes doctrine#1353
@greg0ire greg0ire mentioned this issue Aug 18, 2023
Merged
greg0ire added a commit to greg0ire/migrations that referenced this issue Aug 18, 2023
@greg0ire
Ditch action in favor of running tool directly
3621abf 
Closes doctrine#1353
derrabus pushed a commit that referenced this issue Aug 18, 2023
@greg0ire
Ditch action in favor of running tool directly (#1354)
2dcf355 
Closes #1353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ditch action in favor of running tool directly greg0ire/migrations
1 participant
@stof