Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#998: Show query and time information when using --query-time #1010

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

bobvandevijver
Copy link
Contributor

Q A
Type bug/improvement
BC Break no
Fixed issues #998

Summary

Always show the queries and their timing when supplying the --query-time option

@greg0ire greg0ire requested a review from goetas June 19, 2020 18:56
@goetas
Copy link
Member

goetas commented Jun 21, 2020

Sorry for the late review... why not just trigger the -vvv option when --query-time is passed rather than changing logging levels at runtime?

@bobvandevijver
Copy link
Contributor Author

Sorry for the late review... why not just trigger the -vvv option when --query-time is passed rather than changing logging levels at runtime?

If I dot that, passing the --query-time would imply debug verbosity, which is not something I would expect. I'm only expecting the lines relevant to my supplied options to be printed, which is what it now does. Otherwise it would be possible that it prints a full debug log (which isn't that extensive at the moment, but still), resulting in the desired output to be "flooded" with information I didn't ask for.

This way, it just makes sure that, without depending on the user set verbosity level (except for quiet obviously), it always print the information requested.

@goetas
Copy link
Member

goetas commented Jun 22, 2020

@bobvandevijver That makes sense.
Thank you!

@goetas goetas added this to the 3.1.0 milestone Jun 22, 2020
@goetas goetas merged commit df6138f into doctrine:master Jun 22, 2020
@bobvandevijver bobvandevijver deleted the improve-query-time branch June 22, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants