Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1024 #1027

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Issue1024 #1027

merged 1 commit into from
Jun 26, 2020

Conversation

shepard8
Copy link
Contributor

Q A
Type improvement
BC Break yes/no
Fixed issues #1024

Summary

The documentation incorrectly suggested to provide the field name in the configuration.

@goetas
Copy link
Member

goetas commented Jun 25, 2020

Duplicate #1018

@goetas goetas closed this Jun 25, 2020
@greg0ire
Copy link
Member

Actually there might be additional value in this PR, see #1024 (comment)

@greg0ire greg0ire reopened this Jun 25, 2020
@greg0ire greg0ire changed the base branch from master to 3.0.x June 25, 2020 18:53
@greg0ire greg0ire requested a review from goetas June 25, 2020 18:53
@goetas
Copy link
Member

goetas commented Jun 26, 2020

I'm sorry, i somehow did not notice that (was using gihub mobile), my bad.

Anyway, looks good to me.

@goetas goetas added this to the 3.0.2 milestone Jun 26, 2020
@greg0ire greg0ire merged commit a673f4e into doctrine:3.0.x Jun 26, 2020
@shepard8 shepard8 deleted the issue1024 branch June 26, 2020 12:10
@github-actions github-actions bot mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@shepard8 @goetas @greg0ire