Repeated $config value #1058
Merged
Repeated $config value #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a repeated value name at the end of this page in the last advanced configuration ($config). I have changed the name of one of them because it can create confusion and it wouldn't work anyways.
stof
requested changes
Sep 30, 2020
docs/en/reference/configuration.rst
Outdated
| $entityManager = EntityManager::create(['driver' => 'pdo_sqlite', 'memory' => true], $config); | ||
|
|
||
| return DependencyFactory::fromEntityManager($config, new ExistingEntityManager($entityManager)); | ||
| return DependencyFactory::fromEntityManager($ORMconfig, new ExistingEntityManager($entityManager)); |
There was a problem hiding this comment.
this is wrong. This one is meant to be $config holding the doctrine/migrations config. the ORM Config is meant to be used in the EntityManager::create call on the previous line.
There was a problem hiding this comment.
I guess you are looing at an old commit? I did a second commit that fixed it, my bad.
There was a problem hiding this comment.
well, Github shows me that your second commit has been done after my review
I was wrong, and changed one of the values that shouldn't change.
stof
approved these changes
Oct 1, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a repeated value name at the end of this page in the last advanced configuration ($config). I have changed the name of one of them because it can create confusion and it wouldn't work anyways.
Summary
URL where you can find the typo:
https://www.doctrine-project.org/projects/doctrine-migrations/en/3.0/reference/configuration.html#advanced