Cast to int the execution time #1063
Conversation
| ->with($config->getTableName(), [ | ||
| $config->getVersionColumnName() => '1230', | ||
| $config->getExecutedAtColumnName() => $executedAt, | ||
| $config->getExecutionTimeColumnName() => 31000, |
There was a problem hiding this comment.
@goetas I understand your approach. I though about the same, but, if you remove the (int) cast, the test still passes. That is why I used mock and assertSame. Wdyt?
There was a problem hiding this comment.
If the issue only happens on Google Spanner, there is no way we are going to get a failing test, since we don't have Google Spanner tested in our CI, right?
There was a problem hiding this comment.
In my PR the test fails if we remove the casting, cause I am using assertSame. Here the SQLite does internal cast, different from Spanner, so the test never fails and this was already covered on other tests.
I would prefer be sure this is an integer. My test makes sure about this. I only could check this using mocks or instead I would have to refactor other classes to avoid mock, but I wanted to impact as low as possible :)
tests/Doctrine/Migrations/Tests/Metadata/Storage/TableMetadataStorageTest.php
Outdated
Show resolved
Hide resolved
goetas
force-pushed
the
cast-to-int-exec-time
branch
from
34180e1 to
42578bf
Compare
… as Google Spanner)
goetas
force-pushed
the
cast-to-int-exec-time
branch
from
42578bf to
b06a386
Compare
|
I have changed the tests to use |
|
Done in #1060 |
Cast to int the execution time (to avoid incompatibilities with RDBMS as Google Spanner)