Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Github Actions #1073

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Migrate to Github Actions #1073

merged 2 commits into from
Nov 19, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Nov 8, 2020

No description provided.

@greg0ire
Copy link
Member Author

greg0ire commented Nov 8, 2020

Argh, will have to fix PHPStan first, running it on 7.4 yields more issues than on 7.1 (maybe it was updated to a more recent version)

UPD: I can't address deprecations and stay compatible with 7.1, so let's run PHPStan on 7.1 I suppose. We don't do that on other Doctrine packages, but we also do not use phpstan/phpstan-deprecation-rules

@greg0ire greg0ire marked this pull request as draft November 8, 2020 19:33
@greg0ire greg0ire force-pushed the migrate-to-ga branch 4 times, most recently from 06e2efc to 20dd783 Compare November 8, 2020 19:46
@greg0ire greg0ire marked this pull request as ready for review November 8, 2020 19:49
This helps in situations when you maintain 2 major branches, which is
our case.
@greg0ire greg0ire merged commit 179ae06 into doctrine:2.3.x Nov 19, 2020
@greg0ire greg0ire added this to the 2.3.1 milestone Nov 19, 2020
@greg0ire greg0ire added the CI label Nov 19, 2020
@greg0ire greg0ire deleted the migrate-to-ga branch November 22, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant