Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom migration template into the documentation #1128

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Add Custom migration template into the documentation #1128

merged 1 commit into from
Feb 22, 2021

Conversation

Holicz
Copy link
Contributor

@Holicz Holicz commented Feb 19, 2021

Q A
Type improvement
BC Break no
Fixed issues #1122

Summary

Added documentation for the custom template. Grammar was checked using grammarly.com but please be aware english is not my first language.

docs/en/reference/custom-configuration.rst Outdated Show resolved Hide resolved
docs/en/reference/custom-configuration.rst Outdated Show resolved Hide resolved
docs/en/reference/custom-configuration.rst Outdated Show resolved Hide resolved
docs/en/reference/custom-configuration.rst Outdated Show resolved Hide resolved
docs/en/reference/custom-configuration.rst Outdated Show resolved Hide resolved
@greg0ire
Copy link
Member

Please associate your email address with your Github account, or change the
email in your commits to an address already associated with it. If you do not
want to expose your personal email address, you may use
$userName@users.noreply.github.com, that way we can still reach you through Github.
Additionally, you will get credit for this contribution on your Github profile.

@Holicz
Copy link
Contributor Author

Holicz commented Feb 21, 2021

Thank you for your time and the review! I accepted all of the comments and verified my email on Github.

@greg0ire greg0ire requested a review from goetas February 21, 2021 15:14
@greg0ire greg0ire merged commit 9112d14 into doctrine:3.1.x Feb 22, 2021
@greg0ire greg0ire added this to the 3.1.1 milestone Feb 22, 2021
@greg0ire
Copy link
Member

Thanks @Holicz !

@Holicz
Copy link
Contributor Author

Holicz commented Feb 23, 2021

I see the documentation was deployed, but the table with all available placeholders is not rendered.

I used a simple table according to this documentation, should I rewrite it to the grid table syntax in another PR? I checked some other parts of the documentation and the grid table is rendered correctly.

@greg0ire
Copy link
Member

greg0ire commented Feb 23, 2021

Yes, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants