Do not use by default transactional DDL when the database engine does not support them

lib/Doctrine/Migrations/AbstractMigration.php

@@ -7,6 +7,8 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\DBALException;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Platforms\MySqlPlatform;
+use Doctrine\DBAL\Platforms\OraclePlatform;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Schema\Schema;
 use Doctrine\Migrations\Exception\AbortMigration;
@@ -52,15 +54,15 @@ public function __construct(Version $version)
     /**
      * Indicates the transactional mode of this migration.
      *
-     * If this function returns true (default) the migration will be executed
+     * If this function returns true (default when the underlying database supports transactional DDL) the migration will be executed
      * in one transaction, otherwise non-transactional state will be used to
      * execute each of the migration SQLs.
      *
      * Extending class should override this function to alter the return value.
      */
     public function isTransactional(): bool
     {
-        return true;
+        return ! ($this->platform instanceof MySqlPlatform || $this->platform instanceof OraclePlatform);
     }
 
     public function getDescription(): string

lib/Doctrine/Migrations/Event/Listeners/AutoCommitListener.php

@@ -7,7 +7,6 @@
 use Doctrine\Common\EventSubscriber;
 use Doctrine\Migrations\Event\MigrationsEventArgs;
 use Doctrine\Migrations\Events;
-use Doctrine\Migrations\Tools\TransactionHelper;
 
 /**
  * Listens for `onMigrationsMigrated` and, if the connection has autocommit
@@ -25,7 +24,7 @@ public function onMigrationsMigrated(MigrationsEventArgs $args): void
             return;
         }
 
-        TransactionHelper::commitIfInTransaction($conn);
+        $conn->commit();
     }
 
     /** {@inheritdoc} */

lib/Doctrine/Migrations/Migrator.php

@@ -9,7 +9,6 @@
 use Doctrine\Migrations\Exception\NoMigrationsToExecute;
 use Doctrine\Migrations\Exception\UnknownMigrationVersion;
 use Doctrine\Migrations\Tools\BytesFormatter;
-use Doctrine\Migrations\Tools\TransactionHelper;
 use Doctrine\Migrations\Version\Direction;
 use Doctrine\Migrations\Version\Version;
 use Symfony\Component\Stopwatch\StopwatchEvent;
@@ -196,14 +195,14 @@ private function executeMigration(
             $this->configuration->dispatchMigrationEvent(Events::onMigrationsMigrated, $direction, $dryRun);
         } catch (Throwable $e) {
             if ($allOrNothing) {
-                TransactionHelper::rollbackIfInTransaction($connection);
+                $connection->rollBack();
             }
 
             throw $e;
         }
 
         if ($allOrNothing) {
-            TransactionHelper::commitIfInTransaction($connection);
+            $connection->commit();
         }
 
         return $sql;

lib/Doctrine/Migrations/Tracking/TableUpdater.php

@@ -9,7 +9,6 @@
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Schema\Schema;
 use Doctrine\DBAL\Schema\Table;
-use Doctrine\Migrations\Tools\TransactionHelper;
 use Throwable;
 
 use function in_array;
@@ -62,12 +61,12 @@ public function updateMigrationTable(): void
                 $this->connection->executeQuery($query);
             }
         } catch (Throwable $e) {
-            TransactionHelper::rollbackIfInTransaction($this->connection);
+            $this->connection->rollBack();
 
             throw $e;
         }
 
-        TransactionHelper::commitIfInTransaction($this->connection);
+        $this->connection->commit();
     }
 
     /**

lib/Doctrine/Migrations/Version/Executor.php

@@ -16,7 +16,6 @@
 use Doctrine\Migrations\Provider\SchemaDiffProviderInterface;
 use Doctrine\Migrations\Stopwatch;
 use Doctrine\Migrations\Tools\BytesFormatter;
-use Doctrine\Migrations\Tools\TransactionHelper;
 use Throwable;
 
 use function count;
@@ -258,7 +257,8 @@ private function executeMigration(
         }
 
         if ($migration->isTransactional()) {
-            TransactionHelper::commitIfInTransaction($this->connection);
+            //commit only if running in transactional mode
+            $this->connection->commit();
         }
 
         $version->setState(State::NONE);
@@ -298,7 +298,7 @@ private function skipMigration(
     ): void {
         if ($migration->isTransactional()) {
             //only rollback transaction if in transactional mode
-            TransactionHelper::rollbackIfInTransaction($this->connection);
+            $this->connection->rollBack();
         }
 
         if (! $migratorConfiguration->isDryRun()) {
@@ -331,7 +331,7 @@ private function migrationError(Throwable $e, Version $version, AbstractMigratio
 
         if ($migration->isTransactional()) {
             //only rollback transaction if in transactional mode
-            TransactionHelper::rollbackIfInTransaction($this->connection);
+            $this->connection->rollBack();
         }
 
         $version->setState(State::NONE);