Look harder for a native connection #1210
Conversation
greg0ire
force-pushed
the
fix-compat-with-dbal-3
branch
from
4c4a3bc to
5c0e06c
Compare
It is not like this could work from another directory than the root of the project.
greg0ire
force-pushed
the
fix-compat-with-dbal-3
branch
from
5c0e06c to
1e98776
Compare
|
Tagging @morozov because we currently have a discussion about deprecating the methods you use to access the PDO connection, see doctrine/dbal#4966 |
|
I think in previous discussions, we established that this |
greg0ire
force-pushed
the
fix-compat-with-dbal-3
branch
3 times, most recently
from
a9bba0b to
f9d5556
Compare
doctrine/dbal 3 switches from inheritance to composition but still provides an accessor for PDO, and it is named like the method in Connection. Unwrapping until that method no longer exists should give the innermost connection regardless of the DBAL version Fixes doctrine#1209
greg0ire
force-pushed
the
fix-compat-with-dbal-3
branch
from
f9d5556 to
c9e0386
Compare
|
Okay, in other words, this class will be broken when DBAL 4 is used eventually and that won't be a problem? In that case, the change looks good. 🙂 |
Yes. Maybe we should create |
|
|
||
| /* Attempt to commit or rollback while no transaction is running | ||
| results in an exception since PHP 8 + pdo_mysql combination */ | ||
| return ! $wrappedConnection instanceof PDO || $wrappedConnection->inTransaction(); | ||
| return ! $innermostConnection instanceof PDO || $innermostConnection->inTransaction(); |
There was a problem hiding this comment.
If the "in transaction" method for the drivers of the platform that don't support transactional DDL is still of interest, it looks like the right course of action is to revive the discussion in PHP internals.
There was a problem hiding this comment.
We are planning to drop the TransactionHelper class in the next major release (ref), so I don't think it will be of interest.
|
fixes #1209 |
doctrine/dbal 3 switches from inheritance to composition but still
provides an accessor for PDO, and it is named like the method in
Connection.
Unwrapping until that method no longer exists should give the innermost
connection regardless of the DBAL version
I hade to adapt some tests to ensure
getWrappedConnectionreturns an object.Fixes #1209
How can I test this?
composer config repositories.greg0ire vcs https://github.com/greg0ire/migrations composer require doctrine/migrations "dev-fix-compat-with-dbal-3 as 3.3.0"