Fixing an issue in the order at which some configuration key are loaded #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is validation that check that the namespace and folder name are set. Namely the validate method in the configuration class. Because of that check we need to make sure that the namespace is set before any migration are loaded, as the check happen there.
mikeSimonson
added a commit
that referenced
this pull request
Feb 17, 2016
Fixing an issue in the order at which some configuration key are loaded
|
@mikeSimonson thanks for solving this issue. May i ask why do you add 2 key => value pair with the same key |
|
@LogansUA thanks for the notice. Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is validation that check that the namespace and folder name are
set. Namely the validate method in the configuration class.
Because of that check we need to make sure that the namespace is set
before any migration are loaded, as the check happen there.